-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to wrap lines in custom code mirror #7857
add option to wrap lines in custom code mirror #7857
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7857 +/- ##
=============================================
- Coverage 71.63% 38.47% -33.16%
+ Complexity 4088 80 -4008
=============================================
Files 1580 1580
Lines 81100 81099 -1
Branches 12068 12068
=============================================
- Hits 58093 31200 -26893
- Misses 19092 47529 +28437
+ Partials 3915 2370 -1545
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@shahsank3t Can you please help take a look at this? |
Thank you @jadami10 for this enhancement. cc: @Jackie-Jiang |
I liked it better on the left since that puts it closer to the start of the lines. so if i wrap, i can immediately move the mouse down and copy/paste. that said, it's not a strong opinion. maybe @Jackie-Jiang can be the tie breaker. |
@shahsank3t Thanks for the review. I kind of like the way @jadami10 puts it on the left since it requires less mouse movement. |
Description
Many of the zookeeper nodes contain quite long metadata, and it's challenging to scroll horizontally to read them.
Note: i had to test with material-ui: 4.12.3 becuase the zookeeper browser is refusing to load locally due to some makeStyles issue
Edit table looks the same

but zk browser now can wrap lines

Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat
, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat
, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notes
and complete the section on Release Notes)Release Notes
Documentation