-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getPredicate() to PredicateEvaluator #7840
Conversation
|
||
@Override | ||
public Predicate.Type getPredicateType() { | ||
return getPredicate().getType(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do _predicate.getType()
instead of function call (which although may not happen at runtime if JVM inlines) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be inlined when there is no other override on getPredicate()
. It is slightly safer this way in case some class overrides the getPredicate()
Codecov Report
@@ Coverage Diff @@
## master #7840 +/- ##
============================================
+ Coverage 71.66% 71.67% +0.01%
+ Complexity 4088 4086 -2
============================================
Files 1579 1579
Lines 80851 80819 -32
Branches 12017 12017
============================================
- Hits 57938 57930 -8
+ Misses 19017 18995 -22
+ Partials 3896 3894 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Add
getPredicate()
toPredicateEvaluator
interface for query explanation purpose