Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getPredicate() to PredicateEvaluator #7840

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

Jackie-Jiang
Copy link
Contributor

Add getPredicate() to PredicateEvaluator interface for query explanation purpose


@Override
public Predicate.Type getPredicateType() {
return getPredicate().getType();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do _predicate.getType() instead of function call (which although may not happen at runtime if JVM inlines) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be inlined when there is no other override on getPredicate(). It is slightly safer this way in case some class overrides the getPredicate()

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #7840 (e9f209a) into master (dfb7fee) will increase coverage by 0.01%.
The diff coverage is 90.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7840      +/-   ##
============================================
+ Coverage     71.66%   71.67%   +0.01%     
+ Complexity     4088     4086       -2     
============================================
  Files          1579     1579              
  Lines         80851    80819      -32     
  Branches      12017    12017              
============================================
- Hits          57938    57930       -8     
+ Misses        19017    18995      -22     
+ Partials       3896     3894       -2     
Flag Coverage Δ
integration1 29.47% <59.57%> (+0.01%) ⬆️
integration2 27.96% <59.57%> (+0.06%) ⬆️
unittests1 68.66% <89.36%> (-0.02%) ⬇️
unittests2 14.60% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...predicate/RegexpLikePredicateEvaluatorFactory.java 27.27% <50.00%> (-1.90%) ⬇️
.../filter/predicate/InPredicateEvaluatorFactory.java 78.26% <86.66%> (-1.54%) ⬇️
...lter/predicate/NotInPredicateEvaluatorFactory.java 79.20% <86.66%> (-1.35%) ⬇️
.../predicate/NotEqualsPredicateEvaluatorFactory.java 77.94% <87.50%> (-2.06%) ⬇️
...ter/predicate/EqualsPredicateEvaluatorFactory.java 83.33% <93.33%> (-1.92%) ⬇️
...lter/predicate/RangePredicateEvaluatorFactory.java 83.90% <94.11%> (+0.41%) ⬆️
...edicate/BaseDictionaryBasedPredicateEvaluator.java 50.00% <100.00%> (+2.00%) ⬆️
...rator/filter/predicate/BasePredicateEvaluator.java 75.00% <100.00%> (+25.00%) ⬆️
...predicate/BaseRawValueBasedPredicateEvaluator.java 86.56% <100.00%> (+0.20%) ⬆️
...icate/FSTBasedRegexpPredicateEvaluatorFactory.java 90.00% <100.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb7fee...e9f209a. Read the comment docs.

@Jackie-Jiang Jackie-Jiang mentioned this pull request Nov 30, 2021
3 tasks
@Jackie-Jiang Jackie-Jiang merged commit d172737 into apache:master Nov 30, 2021
@Jackie-Jiang Jackie-Jiang deleted the predicate_evaluator branch November 30, 2021 18:47
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants