Support non-selection-only GRPC server request handler #7839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7839 +/- ##
============================================
- Coverage 71.46% 68.35% -3.11%
+ Complexity 4079 4012 -67
============================================
Files 1583 1194 -389
Lines 81871 59366 -22505
Branches 12239 9173 -3066
============================================
- Hits 58509 40580 -17929
+ Misses 19393 15922 -3471
+ Partials 3969 2864 -1105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
walterddr
force-pushed
the
add_server_grpc
branch
from
a98d316 to
d12a963
Compare
Jackie-Jiang
reviewed
Dec 7, 2021
...-core/src/main/java/org/apache/pinot/core/query/request/context/utils/QueryContextUtils.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/StreamingInstanceResponsePlanNode.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/operator/streaming/StreamingResponseUtils.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/operator/StreamingInstanceResponseOperator.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableUtils.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
reviewed
Dec 8, 2021
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV2.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableUtils.java
Outdated
Show resolved
Hide resolved
walterddr
force-pushed
the
add_server_grpc
branch
from
9f874a4 to
4f9012b
Compare
walterddr
force-pushed
the
add_server_grpc
branch
from
4f9012b to
3871b01
Compare
Jackie-Jiang
approved these changes
Dec 13, 2021
| public DataTable toMetadataOnlyDataTable() { | ||
| DataTable destDataTable = DataTableBuilder.getEmptyDataTable(); | ||
| destDataTable.getMetadata().putAll(this.getMetadata()); | ||
| if (!this.getExceptions().isEmpty()) { |
There was a problem hiding this comment.
This method needs to be implemented in each individual data table implementation as in V2 the exception is stored in _metadata, but in V3 it is stored as a separate map. We don't want to add the exception again if it is already stored in _metadata
There was a problem hiding this comment.
a. good catch.. btw when are we deprecating v2 :-P ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently GRPCServer only support selection-only queries.
This PR adds support for streaming back all other types of query response from server to broker.
This makes possible for the next step --> stream processing GRPC broker handler that can do partial data reduce in streaming fashion.