Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added extraEnv, envFrom to statefulset template #7833

Merged
merged 1 commit into from
Dec 1, 2021
Merged

added extraEnv, envFrom to statefulset template #7833

merged 1 commit into from
Dec 1, 2021

Conversation

shucle-devops
Copy link
Contributor

Description

  • There was no way to inject env var like TZ to presto container on presto's helm chart.
  • I added extraEnv, envFrom to presto helm template, and initialized those values with empty array.
  • It works fine and users will be able to use custom env vars from presto containers.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

  • You can set extraEnv, envFrom on presto helm values.

Documentation

@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 December 1, 2021 01:18
Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding this!

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #7833 (89819cc) into master (1e25962) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7833      +/-   ##
============================================
- Coverage     71.67%   71.65%   -0.03%     
  Complexity     4089     4089              
============================================
  Files          1579     1579              
  Lines         80843    80843              
  Branches      12010    12010              
============================================
- Hits          57944    57926      -18     
- Misses        18995    19019      +24     
+ Partials       3904     3898       -6     
Flag Coverage Δ
integration1 29.23% <ø> (-0.23%) ⬇️
integration2 27.94% <ø> (-0.10%) ⬇️
unittests1 68.68% <ø> (+0.02%) ⬆️
unittests2 14.59% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...data/manager/realtime/SegmentCommitterFactory.java 64.70% <0.00%> (-29.42%) ⬇️
...a/manager/realtime/RealtimeSegmentDataManager.java 50.00% <0.00%> (-25.00%) ⬇️
...ache/pinot/core/operator/docidsets/OrDocIdSet.java 86.36% <0.00%> (-11.37%) ⬇️
...er/api/resources/LLCSegmentCompletionHandlers.java 53.46% <0.00%> (-8.92%) ⬇️
...altime/ServerSegmentCompletionProtocolHandler.java 49.52% <0.00%> (-8.58%) ⬇️
...e/data/manager/realtime/SplitSegmentCommitter.java 53.84% <0.00%> (-7.70%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 47.66% <0.00%> (-7.26%) ⬇️
.../predicate/NotEqualsPredicateEvaluatorFactory.java 77.33% <0.00%> (-2.67%) ⬇️
...ot/common/protocols/SegmentCompletionProtocol.java 93.80% <0.00%> (-1.91%) ⬇️
...r/validation/RealtimeSegmentValidationManager.java 74.28% <0.00%> (-1.43%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e25962...89819cc. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 34782f5 into apache:master Dec 1, 2021
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants