Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Pinot Connection properties from JDBC driver #7822

Merged

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Nov 23, 2021

Description

Passing info properties also to Pinot Connection.

Release Notes

  • Pinot client accepts configures from JDBC Driver info properties

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #7822 (1468b7d) into master (a74d944) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7822   +/-   ##
=========================================
  Coverage     71.63%   71.64%           
- Complexity     4087     4088    +1     
=========================================
  Files          1579     1579           
  Lines         80810    80832   +22     
  Branches      12006    12010    +4     
=========================================
+ Hits          57892    57915   +23     
- Misses        19020    19026    +6     
+ Partials       3898     3891    -7     
Flag Coverage Δ
integration1 29.38% <ø> (+0.12%) ⬆️
integration2 27.95% <ø> (+0.03%) ⬆️
unittests1 68.67% <ø> (+<0.01%) ⬆️
unittests2 14.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nction/DistinctCountBitmapAggregationFunction.java 41.45% <0.00%> (-15.03%) ⬇️
...ache/pinot/core/operator/docidsets/OrDocIdSet.java 86.36% <0.00%> (-13.64%) ⬇️
.../predicate/NotEqualsPredicateEvaluatorFactory.java 69.33% <0.00%> (-10.67%) ⬇️
...inot/core/util/SegmentCompletionProtocolUtils.java 57.69% <0.00%> (-7.70%) ⬇️
...l/segment/index/readers/OnHeapFloatDictionary.java 90.00% <0.00%> (-5.00%) ⬇️
...gregation/function/StUnionAggregationFunction.java 73.52% <0.00%> (-2.95%) ⬇️
.../org/apache/pinot/core/startree/StarTreeUtils.java 69.89% <0.00%> (-2.16%) ⬇️
...e/pinot/broker/broker/helix/BaseBrokerStarter.java 75.14% <0.00%> (-1.69%) ⬇️
...e/pinot/segment/local/io/util/PinotDataBitSet.java 95.62% <0.00%> (-1.46%) ⬇️
...ion/groupby/AggregationGroupByTrimmingService.java 93.47% <0.00%> (-1.45%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74d944...1468b7d. Read the comment docs.

@xiangfu0 xiangfu0 force-pushed the support_passing_properties_from_jdbc branch 2 times, most recently from 0317569 to 35af71f Compare November 24, 2021 00:18
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangfu0 xiangfu0 force-pushed the support_passing_properties_from_jdbc branch from 35af71f to 1468b7d Compare November 24, 2021 01:00
@xiangfu0 xiangfu0 merged commit 90f5881 into apache:master Nov 24, 2021
@xiangfu0 xiangfu0 deleted the support_passing_properties_from_jdbc branch November 24, 2021 09:01
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants