Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default Dockerfile CMD to -help #7767

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

walterddr
Copy link
Contributor

Default docker entrypoint is set to "run" which is an invalid argument to the ENTRYPOINT pinot-admin.sh.

setting it to -help instead.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #7767 (24e11ae) into master (362f3e1) will decrease coverage by 6.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7767      +/-   ##
============================================
- Coverage     71.63%   65.16%   -6.47%     
+ Complexity     4079     4076       -3     
============================================
  Files          1578     1533      -45     
  Lines         80629    78764    -1865     
  Branches      11982    11780     -202     
============================================
- Hits          57756    51330    -6426     
- Misses        18981    23781    +4800     
+ Partials       3892     3653     -239     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 68.60% <ø> (-0.01%) ⬇️
unittests2 14.59% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
...not/common/exception/HttpErrorStatusException.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/startree/plan/StarTreeDocIdSetPlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ot/common/restlet/resources/TableMetadataInfo.java 0.00% <0.00%> (-100.00%) ⬇️
... and 355 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362f3e1...24e11ae. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 05b74b4 into apache:master Nov 15, 2021
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
@walterddr walterddr deleted the hotfix_default_entry branch December 6, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants