Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeColumn, timeUnit and totalDocs to the json segment metadata #7765

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Nov 13, 2021

Add the missing timeColumn, timeUnit and totalDocs info to the json segment metadata

@Jackie-Jiang Jackie-Jiang changed the title Add timeColumn and timeUnit to the json segment metadata Add timeColumn, timeUnit and totalDocs to the json segment metadata Nov 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #7765 (1b22021) into master (781f5cd) will decrease coverage by 7.36%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7765      +/-   ##
============================================
- Coverage     71.67%   64.30%   -7.37%     
+ Complexity     4076     4002      -74     
============================================
  Files          1578     1569       -9     
  Lines         80625    80284     -341     
  Branches      11982    11945      -37     
============================================
- Hits          57785    51624    -6161     
- Misses        18945    24995    +6050     
+ Partials       3895     3665     -230     
Flag Coverage Δ
integration1 29.21% <0.00%> (-0.22%) ⬇️
integration2 27.93% <0.00%> (+0.13%) ⬆️
unittests1 68.66% <66.66%> (+0.06%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...egment/spi/index/metadata/SegmentMetadataImpl.java 74.56% <66.66%> (-0.14%) ⬇️
...pinot/controller/recommender/io/ConfigManager.java 0.00% <0.00%> (-100.00%) ⬇️
...troller/recommender/io/metadata/FieldMetadata.java 0.00% <0.00%> (-100.00%) ⬇️
...roller/recommender/rules/impl/BloomFilterRule.java 0.00% <0.00%> (-100.00%) ⬇️
...oller/api/resources/PinotControllerAppConfigs.java 0.00% <0.00%> (-100.00%) ⬇️
...ler/recommender/data/generator/BytesGenerator.java 0.00% <0.00%> (-100.00%) ⬇️
...er/recommender/io/metadata/SchemaWithMetaData.java 0.00% <0.00%> (-100.00%) ⬇️
...r/recommender/rules/impl/AggregateMetricsRule.java 0.00% <0.00%> (-100.00%) ⬇️
.../recommender/exceptions/InvalidInputException.java 0.00% <0.00%> (-100.00%) ⬇️
.../recommender/rules/io/configs/PartitionConfig.java 0.00% <0.00%> (-100.00%) ⬇️
... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781f5cd...1b22021. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit d547920 into apache:master Nov 15, 2021
@Jackie-Jiang Jackie-Jiang deleted the segment_metadata_json branch November 15, 2021 19:51
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants