extend a bit on the FileUploadDownloadClient #7751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
force-pushed
the
extend_file_client
branch
from
22d0d0e to
b822d0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #7751 +/- ##
=============================================
+ Coverage 30.83% 71.54% +40.70%
- Complexity 0 4067 +4067
=============================================
Files 1568 1577 +9
Lines 80194 80552 +358
Branches 11929 11971 +42
=============================================
+ Hits 24731 57629 +32898
+ Misses 53345 19047 -34298
- Partials 2118 3876 +1758
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
Nov 11, 2021
| @@ -578,6 +578,18 @@ public SimpleHttpResponse sendDeleteRequest(URI uri, String authToken) | |||
| return sendRequest(requestBuilder.build()); | |||
| } | |||
|
|
|||
| public SimpleHttpResponse postJsonRequest(URI uri, String jsonRequestBody, String authToken) | |||
There was a problem hiding this comment.
Annotate jsonRequestBody as nullable.
Side question: Could authToken be null? Will it work properly when it is null?
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
Extended a bit on the FileUploadDownloadClient to send post request with json body. I tried not to make it too generic, like passing in http params and headers, but lemme know if that's actually preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extended a bit on the FileUploadDownloadClient to send post request with json body. I tried not to make it too generic, like passing in http params and headers, but lemme know if that's actually preferred.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation