Handle fields missing in the source in ParquetNativeRecordReader #7742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankshriv
approved these changes
Nov 11, 2021
xiangfu0
approved these changes
Nov 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #7742 +/- ##
============================================
+ Coverage 70.18% 71.52% +1.33%
- Complexity 4034 4061 +27
============================================
Files 1575 1577 +2
Lines 80289 80542 +253
Branches 11938 11967 +29
============================================
+ Hits 56353 57608 +1255
+ Misses 20061 19053 -1008
- Partials 3875 3881 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Fix ParquetNativeRecordExtractor for fields missing in the source * nit * Same bug in proto
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
…che#7742) * Fix ParquetNativeRecordExtractor for fields missing in the source * nit * Same bug in proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParquetNativeRecordReader was not handling fields which were missing at source. This is a common case when transform functions are applied, that the record reader gets a list of fields and not all of them may be in the source.
Modified test to catch this case.