Add getSelectedSegments API #7651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtao15
reviewed
Oct 27, 2021
...ler/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
Show resolved
Hide resolved
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Outdated
Show resolved
Hide resolved
jackjlli
force-pushed
the
add-select-segment-api
branch
2 times, most recently
from
bd0d4d1 to
4b0fa22
Compare
snleee
approved these changes
Oct 28, 2021
...ler/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
Show resolved
Hide resolved
jackjlli
force-pushed
the
add-select-segment-api
branch
from
4b0fa22 to
52171bf
Compare
jackjlli
force-pushed
the
add-select-segment-api
branch
from
52171bf to
04de569
Compare
Codecov Report
@@ Coverage Diff @@
## master #7651 +/- ##
=============================================
- Coverage 71.75% 30.94% -40.81%
=============================================
Files 1576 1567 -9
Lines 79966 79684 -282
Branches 11843 11826 -17
=============================================
- Hits 57377 24661 -32716
- Misses 18730 52921 +34191
+ Partials 3859 2102 -1757
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
Co-authored-by: Jack Li(Analytics Engineering) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
getSelectedSegmentsAPI inPinotSegmentRestletResourceclass. This API is useful to get the segments which are used for serving queries (i.e. the set of segments that are used in routing table) given the start and end timestamps.If the table is a refresh use case, the value of start and end timestamp is voided, since there is no time column for refresh use case; instead, the whole qualified segments will be returned.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation