support large payload in zk put API #7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding this! Can you add a test for this? |
| @@ -139,7 +140,17 @@ public SuccessResponse putData( | |||
| @ApiParam(value = "expectedVersion", required = true, defaultValue = "-1") @QueryParam("expectedVersion") | |||
| @DefaultValue("-1") String expectedVersion, | |||
| @ApiParam(value = "accessOption", required = true, defaultValue = "1") @QueryParam("accessOption") | |||
| @DefaultValue("1") String accessOption) { | |||
| @DefaultValue("1") String accessOption, | |||
| @ApiParam(value = "payload") @Nullable Payload payload | |||
There was a problem hiding this comment.
We don't want it to be an api param, but the actual payload for the PUT http call. The payload should be the same as the content, but not as an api param. Also we need to change content to be optional
galalen
force-pushed
the
zk-large-payload-support
branch
from
ffb519c to
38207ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #7364 +/- ##
============================================
+ Coverage 71.38% 71.46% +0.08%
- Complexity 4081 4083 +2
============================================
Files 1583 1583
Lines 81863 81868 +5
Branches 12238 12239 +1
============================================
+ Hits 58434 58507 +73
+ Misses 19466 19403 -63
+ Partials 3963 3958 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
galalen
force-pushed
the
zk-large-payload-support
branch
from
38207ba to
354080d
Compare
|
@Jackie-Jiang can you check the PR now, I'll be updating tests coverage |
Jackie-Jiang
approved these changes
Nov 22, 2021
| @@ -0,0 +1,101 @@ | |||
| package org.apache.pinot.controller.api; | |||
There was a problem hiding this comment.
Missing license header
| ) { | ||
|
|
||
| if (payload != null) { | ||
| path = payload.getPath(); |
There was a problem hiding this comment.
We should only override the value when it is provided in the payload
There was a problem hiding this comment.
@Jackie-Jiang I've updated the requested changes
galalen
force-pushed
the
zk-large-payload-support
branch
from
354080d to
25b6431
Compare
draft remove query_param from payload rename payload content to data, remove required field in query params add test case for zk put method
update format
Jackie-Jiang
force-pushed
the
zk-large-payload-support
branch
from
25b6431 to
24183b3
Compare
Jackie-Jiang
force-pushed
the
zk-large-payload-support
branch
from
24183b3 to
36c2385
Compare
kriti-sc
pushed a commit
to kriti-sc/incubator-pinot
that referenced
this pull request
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support large payload in ZK put API, solve issue 7305
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation