Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalMatchLabels to helm chart. #7177

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

mikecdavis-dd
Copy link
Contributor

Description

Adds additionalMatchLabels to the helm values to allow customization of the StatefulSets matchLabels. This configuration will allow for a safe upgrade from chart version 0.2.3 -> 0.2.5 as-is, but also allow for safe upgrades from 0.2.4 -> 0.2.5 with the addition of a additionalMatchLabels option.

Resolves issue: #7176

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

This PR adds a additionalMatchLabels option to customize the StatefulSet match labels. This can be used to maintain multiple StatefulSets within the same kubernetes namespace or to simply maintain tighter control over the associated match labels. Special consideration should be taken when using the additionalMatchLabels option as is can break backwards compatibility.

If upgrading from chart version <0.2.3 then no additional configuration is needed.

If upgrading from chart verion 0.2.4 then the following option needs to be added to values.yaml to upgrade with zero-downtime.

additionalMatchLabels:
  chart: pinot-0.2.4

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #7177 (ba5e555) into master (6d0ab91) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7177      +/-   ##
============================================
- Coverage     73.49%   73.46%   -0.04%     
  Complexity       92       92              
============================================
  Files          1500     1500              
  Lines         73758    73758              
  Branches      10637    10637              
============================================
- Hits          54209    54183      -26     
- Misses        16005    16037      +32     
+ Partials       3544     3538       -6     
Flag Coverage Δ
integration 41.80% <ø> (-0.10%) ⬇️
unittests 65.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntroller/helix/core/minion/TaskMetricsEmitter.java 77.27% <0.00%> (-9.10%) ⬇️
...er/starter/helix/SegmentMessageHandlerFactory.java 68.49% <0.00%> (-6.85%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 46.90% <0.00%> (-5.68%) ⬇️
...core/query/executor/ServerQueryExecutorV1Impl.java 81.42% <0.00%> (-4.92%) ⬇️
...lix/core/minion/PinotHelixTaskResourceManager.java 72.00% <0.00%> (-4.67%) ⬇️
...mpl/dictionary/DoubleOffHeapMutableDictionary.java 58.51% <0.00%> (-4.26%) ⬇️
...pinot/core/query/request/context/TimerContext.java 91.66% <0.00%> (-4.17%) ⬇️
...server/starter/helix/HelixInstanceDataManager.java 80.00% <0.00%> (-2.59%) ⬇️
...not/broker/broker/helix/ClusterChangeMediator.java 78.02% <0.00%> (-2.20%) ⬇️
...e/impl/dictionary/IntOffHeapMutableDictionary.java 78.72% <0.00%> (-1.07%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0ab91...ba5e555. Read the comment docs.

@xiangfu0 xiangfu0 self-requested a review February 14, 2022 19:19
@xiangfu0 xiangfu0 merged commit 88db0fb into apache:master Feb 14, 2022
xiangfu0 pushed a commit to xiangfu0/pinot that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants