[Multi-stage] Ser/de stage plan in parallel #12363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
enhancement
multi-stage
walterddr
approved these changes
Feb 4, 2024
walterddr
reviewed
Feb 4, 2024
| } | ||
| try { | ||
| CompletableFuture.allOf(submissionStubs).get(deadlineMs - System.currentTimeMillis(), TimeUnit.MILLISECONDS); | ||
| CompletableFuture.allOf(stageSubmissionStubs).get(deadlineMs - System.currentTimeMillis(), TimeUnit.MILLISECONDS); |
There was a problem hiding this comment.
looks like there're some issues with submission stub NPE. PTAL
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12363 +/- ##
============================================
+ Coverage 61.68% 61.69% +0.01%
- Complexity 207 1155 +948
============================================
Files 2426 2426
Lines 132674 132675 +1
Branches 20502 20506 +4
============================================
+ Hits 81838 81859 +21
+ Misses 44832 44802 -30
- Partials 6004 6014 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
force-pushed
the
parallel_deserialize_query_plan
branch
from
f623eb4 to
7b80861
Compare
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making stage plan serialization (on broker) and deserialization (on server) execute in parallel