Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multistage][bugfix] fix literal query return multiple duplicate results #12240

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

walterddr
Copy link
Contributor

this fixes #11821

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1cc17c) 61.53% compared to head (76cdf46) 61.50%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12240      +/-   ##
============================================
- Coverage     61.53%   61.50%   -0.03%     
  Complexity      207      207              
============================================
  Files          2416     2416              
  Lines        131177   131181       +4     
  Branches      20245    20247       +2     
============================================
- Hits          80717    80685      -32     
- Misses        44570    44601      +31     
- Partials       5890     5895       +5     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.49% <100.00%> (+<0.01%) ⬆️
java-21 27.70% <0.00%> (-33.69%) ⬇️
skip-bytebuffers-false 61.50% <100.00%> (-0.03%) ⬇️
skip-bytebuffers-true 27.69% <0.00%> (-33.68%) ⬇️
temurin 61.50% <100.00%> (-0.03%) ⬇️
unittests 61.50% <100.00%> (-0.03%) ⬇️
unittests1 46.59% <100.00%> (-0.04%) ⬇️
unittests2 27.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you add one example in integration tests and quickstart?

@walterddr walterddr merged commit 23c1e5f into apache:master Jan 8, 2024
19 checks passed
@walterddr
Copy link
Contributor Author

lgtm, can you add one example in integration tests and quickstart?

this one is trivial and i dont think we need an integration test. we will once we support a more complex literal join table type queries.

@Jackie-Jiang Jackie-Jiang added multi-stage Related to the multi-stage query engine bugfix labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[multistage] SELECT 1 returns multiple rows
4 participants