-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multistage] Early terminate SortOperator if there is a limit #11334
Conversation
71692e6
to
ce76feb
Compare
Codecov Report
@@ Coverage Diff @@
## master #11334 +/- ##
=============================================
- Coverage 61.50% 14.26% -47.24%
+ Complexity 6512 494 -6018
=============================================
Files 2233 2234 +1
Lines 120084 120155 +71
Branches 18223 18235 +12
=============================================
- Hits 73853 17136 -56717
- Misses 40828 101605 +60777
+ Partials 5403 1414 -3989
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1398 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3b7dfd3
to
d3262af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes are not needed. Basically we want to make it a regular case where receiving mailbox can be closed before sending mailbox finishes all the blocks
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/SendingMailbox.java
Outdated
Show resolved
Hide resolved
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java
Outdated
Show resolved
Hide resolved
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java
Outdated
Show resolved
Hide resolved
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java
Outdated
Show resolved
Hide resolved
497da09
to
2c089de
Compare
2ab8c2b
to
e737e90
Compare
15e2b6b
to
e37cfe3
Compare
e37cfe3
to
932f182
Compare
This is for join query or selection query without order by.
e.g.