-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup HLC code #11326
Cleanup HLC code #11326
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11326 +/- ##
=============================================
+ Coverage 0.11% 68.50% +68.39%
- Complexity 0 6536 +6536
=============================================
Files 2239 2233 -6
Lines 120424 119927 -497
Branches 18215 18183 -32
=============================================
+ Hits 137 82161 +82024
+ Misses 120267 31931 -88336
- Partials 20 5835 +5815
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1941 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConsumerFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow-up for #11017 where we removed support for high/stream level consumers in Apache Pinot. This PR makes the following changes:
HLRealtimeSegmentDataManager
and support for it inRealtimeTableDataManager
StreamConsumerFactory#createStreamLevelConsumer
to throwUnsupportedException
by default