Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup HLC code #11326

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Cleanup HLC code #11326

merged 4 commits into from
Aug 14, 2023

Conversation

navina
Copy link
Contributor

@navina navina commented Aug 11, 2023

Follow-up for #11017 where we removed support for high/stream level consumers in Apache Pinot. This PR makes the following changes:

  • Deletes the kafka and pulsar stream level connectors
  • Removes HLRealtimeSegmentDataManager and support for it in RealtimeTableDataManager
  • Made pinot-spi changes in StreamConsumerFactory#createStreamLevelConsumer to throw UnsupportedException by default

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #11326 (1560d7b) into master (d6b1b4f) will increase coverage by 68.39%.
Report is 7 commits behind head on master.
The diff coverage is 77.77%.

@@              Coverage Diff              @@
##             master   #11326       +/-   ##
=============================================
+ Coverage      0.11%   68.50%   +68.39%     
- Complexity        0     6536     +6536     
=============================================
  Files          2239     2233        -6     
  Lines        120424   119927      -497     
  Branches      18215    18183       -32     
=============================================
+ Hits            137    82161    +82024     
+ Misses       120267    31931    -88336     
- Partials         20     5835     +5815     
Flag Coverage Δ
integration1 21.04% <66.66%> (?)
integration1temurin11 ?
integration1temurin17 ?
integration1temurin20 ?
integration2 25.64% <72.22%> (?)
integration2temurin11 ?
integration2temurin17 ?
integration2temurin20 ?
java-11 68.39% <77.77%> (?)
java-17 68.30% <77.77%> (?)
java-20 68.28% <77.77%> (?)
temurin 68.50% <77.77%> (?)
unittests1 67.33% <16.66%> (?)
unittests1temurin17 ?
unittests1temurin20 ?
unittests2 14.66% <0.00%> (?)
unittests2temurin11 ?
unittests2temurin17 ?
unittests2temurin20 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...mmon/request/context/OrderByExpressionContext.java 70.37% <ø> (+70.37%) ⬆️
...ot/plugin/stream/kafka20/KafkaConsumerFactory.java 100.00% <ø> (+100.00%) ⬆️
.../plugin/stream/kinesis/KinesisConsumerFactory.java 0.00% <ø> (ø)
...ot/plugin/stream/pulsar/PulsarConsumerFactory.java 33.33% <ø> (+33.33%) ⬆️
...apache/pinot/spi/stream/StreamConsumerFactory.java 83.33% <0.00%> (+83.33%) ⬆️
...uery/SelectionPartiallyOrderedByDescOperation.java 80.00% <50.00%> (+80.00%) ⬆️
...ata/manager/realtime/RealtimeTableDataManager.java 70.64% <86.66%> (+70.64%) ⬆️

... and 1941 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@navina navina marked this pull request as ready for review August 12, 2023 06:06
Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackie-Jiang Jackie-Jiang merged commit f25f3ed into apache:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants