[multistage] Support multi-value aggregation functions #11216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #11216 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2227 2229 +2
Lines 119594 119803 +209
Branches 18099 18126 +27
==========================================
Hits 137 137
- Misses 119437 119646 +209
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
force-pushed
the
v2-mv-aggregation
branch
2 times, most recently
from
b3046a6 to
5ee6ad0
Compare
xiangfu0
force-pushed
the
v2-mv-aggregation
branch
from
5ee6ad0 to
a40a886
Compare
Jackie-Jiang
approved these changes
Jul 31, 2023
walterddr
reviewed
Jul 31, 2023
| PERCENTILERAWTDIGESTMV("percentileRawTDigestMV"), | ||
| PERCENTILEKLLMV("percentileKLLMV"), | ||
| PERCENTILERAWKLLMV("percentileRawKLLMV"), | ||
| COUNTMV("countMV", null, SqlKind.OTHER_FUNCTION, SqlFunctionCategory.USER_DEFINED_FUNCTION, |
There was a problem hiding this comment.
can we add unit-tests in the json resources?
walterddr
reviewed
Jul 31, 2023
...-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java
Show resolved
Hide resolved
xiangfu0
force-pushed
the
v2-mv-aggregation
branch
from
a40a886 to
44c8682
Compare
s0nskar
pushed a commit
to s0nskar/pinot
that referenced
this pull request
Aug 10, 2023
* temp * Support multi-value aggregation functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multi-value aggregation functions: