Allow liveness check using query parameter during server shutdown #10111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterddr
reviewed
Jan 11, 2023
| @@ -46,6 +48,9 @@ | |||
| @Path("/") | |||
| public class HealthCheckResource { | |||
|
|
|||
| @Inject | |||
| private AtomicBoolean _shutDownInProgress; | |||
There was a problem hiding this comment.
In AdminApiApplication
walterddr
approved these changes
Jan 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #10111 +/- ##
============================================
+ Coverage 70.42% 70.46% +0.03%
- Complexity 5745 5748 +3
============================================
Files 1992 1995 +3
Lines 107980 108021 +41
Branches 16415 16421 +6
============================================
+ Hits 76050 76122 +72
+ Misses 26593 26577 -16
+ Partials 5337 5322 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #9915, also allow liveness check using query parameter to pass the shut down filter.