Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Use correct exception import in TableRebalancer. #10025

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

mayankshriv
Copy link
Contributor

@mayankshriv mayankshriv commented Dec 22, 2022

The ZkBadVersionException exception is being imported from incorrect library. This causes exception to be not caught correctly and leads to various issues.

The `ZkBadVersionException` exception is being imported from incorrect library.
This causes exception to be not caught correctly and leads to various issues.
@mayankshriv
Copy link
Contributor Author

mayankshriv commented Dec 22, 2022

Duplicate of #10024, will close the former (it is failing lint check).

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #10025 (b704542) into master (36c82b6) will increase coverage by 36.40%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #10025       +/-   ##
=============================================
+ Coverage     32.54%   68.95%   +36.40%     
- Complexity      200     5682     +5482     
=============================================
  Files          1992     1992               
  Lines        107339   107339               
  Branches      16318    16318               
=============================================
+ Hits          34935    74014    +39079     
+ Misses        69355    28119    -41236     
- Partials       3049     5206     +2157     
Flag Coverage Δ
integration2 24.40% <ø> (+0.17%) ⬆️
unittests1 67.91% <ø> (?)
unittests2 13.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntroller/helix/core/rebalance/TableRebalancer.java 74.04% <ø> (ø)
...transform/function/IsNotNullTransformFunction.java 65.51% <0.00%> (-3.45%) ⬇️
...controller/helix/core/minion/PinotTaskManager.java 54.83% <0.00%> (-1.47%) ⬇️
...r/validation/RealtimeSegmentValidationManager.java 72.97% <0.00%> (-1.36%) ⬇️
...ntroller/helix/core/PinotHelixResourceManager.java 71.09% <0.00%> (-0.06%) ⬇️
...pache/pinot/core/query/utils/idset/EmptyIdSet.java 25.00% <0.00%> (ø)
...ot/common/function/scalar/ComparisonFunctions.java 42.85% <0.00%> (ø)
...anager/realtime/SegmentBuildTimeLeaseExtender.java 63.23% <0.00%> (ø)
.../helix/core/realtime/SegmentCompletionManager.java 72.15% <0.00%> (+0.20%) ⬆️
...nMaxValueBasedSelectionOrderByCombineOperator.java 75.17% <0.00%> (+0.70%) ⬆️
... and 1145 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snleee snleee merged commit 36cb37b into apache:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants