Support the cross-account access using IAM role for S3 PinotFS #10009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When accountA tries to access data in S3 bucket owned by accountB, AWS provides a way to establish the access to the S3 bucket using cross-account IAM role. This approach is preferred in some cases because `accountKey, secretKey` doesn't need to be exposed. https://repost.aws/knowledge-center/cross-account-access-s3
|
This is a bit complex to add the test because it involves in multiple AWS accounts to try out. I have tested this locally using 2 different AWS accounts and the IAM role based access was successfully established. |
navina
approved these changes
Dec 20, 2022
...ns/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3Config.java
Outdated
Show resolved
Hide resolved
...s/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #10009 +/- ##
=============================================
+ Coverage 25.06% 70.40% +45.33%
- Complexity 44 5681 +5637
=============================================
Files 1979 1992 +13
Lines 106930 107324 +394
Branches 16277 16318 +41
=============================================
+ Hits 26800 75558 +48758
+ Misses 77405 26494 -50911
- Partials 2725 5272 +2547
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snleee
force-pushed
the
s3fs-iam-role
branch
from
4cbfe76 to
447e823
Compare
|
Yeah, I also haven't figured out how to write a test for this. I tried doing it via Localstack once but it has some bugs with mock IAM due to which the access doesn't work properly if you create multiple accounts. |
KKcorps
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DM-404
When accountA tries to access data in S3 bucket owned by accountB, AWS provides a way to establish the access to the S3 bucket using cross-account IAM role. This approach is preferred in some cases because
accountKey, secretKeydoesn't need to be exposed.https://repost.aws/knowledge-center/cross-account-access-s3