Handling null cases in sum,min,max series builders (#14084)

apache · Sep 26, 2024 · 7668b21 · 7668b21
1 parent 6908bc2
commit 7668b21
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/...ies-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MaxTimeSeriesBuilder.java b/...ies-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MaxTimeSeriesBuilder.java
@@ -39,7 +39,7 @@ public MaxTimeSeriesBuilder(String id, TimeBuckets timeBuckets, List<String> tag
 
   @Override
   public void addValueAtIndex(int timeBucketIndex, Double value) {
-    if (_values[timeBucketIndex] == null || value > _values[timeBucketIndex]) {
+    if (value != null && (_values[timeBucketIndex] == null || value > _values[timeBucketIndex])) {
       _values[timeBucketIndex] = value;
     }
   }

diff --git a/...ies-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MinTimeSeriesBuilder.java b/...ies-spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/MinTimeSeriesBuilder.java
@@ -39,7 +39,7 @@ public MinTimeSeriesBuilder(String id, TimeBuckets timeBuckets, List<String> tag
 
   @Override
   public void addValueAtIndex(int timeBucketIndex, Double value) {
-    if (_values[timeBucketIndex] == null || value < _values[timeBucketIndex]) {
+    if (value != null && (_values[timeBucketIndex] == null || value < _values[timeBucketIndex])) {
       _values[timeBucketIndex] = value;
     }
   }

diff --git a/...spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/SummingTimeSeriesBuilder.java b/...spi/src/main/java/org/apache/pinot/tsdb/spi/series/builders/SummingTimeSeriesBuilder.java
@@ -39,7 +39,9 @@ public SummingTimeSeriesBuilder(String id, TimeBuckets timeBuckets, List<String>
 
   @Override
   public void addValueAtIndex(int timeBucketIndex, Double value) {
-    _values[timeBucketIndex] = (_values[timeBucketIndex] == null ? 0 : _values[timeBucketIndex]) + value;
+    if (value != null) {
+      _values[timeBucketIndex] = (_values[timeBucketIndex] == null ? 0.0 : _values[timeBucketIndex]) + value;
+    }
   }
 
   @Override