Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix ClusterActorLoggingSpec #808

Merged
merged 2 commits into from
Dec 12, 2023
Merged

try to fix ClusterActorLoggingSpec #808

merged 2 commits into from
Dec 12, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Nov 21, 2023 •
edited
Loading

relates to #795 - #796 did not help

  • it seems like this filter-leeway is the right timeout
  • this test never fails for me - so this is a bit painful to get the CI issue fixed

@pjfanning pjfanning changed the title [DO NOT MERGE] try to fix test try to fix ClusterActorLoggingSpec Nov 21, 2023
mdedetrich
mdedetrich approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit cc8bf76 into apache:main Dec 12, 2023
@pjfanning pjfanning deleted the test-timeout branch December 12, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @mdedetrich