feat: Add multi java lts support. #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Jan 27, 2024
docs/src/main/java-jdk21/docs/actors/classical/OptimizedActorWithJava21.java
Outdated
Show resolved
Hide resolved
|
|
pjfanning
requested changes
Jan 27, 2024
|
@pjfanning I think it should be fine now |
He-Pin
commented
Jan 27, 2024
| case Msg1 msg1 -> receiveMsg1(msg1); | ||
| case Msg2 msg2 -> receiveMsg2(msg2); | ||
| case Msg3 msg3 -> receiveMsg3(msg3); | ||
| default -> unhandled(msg); |
pjfanning
reviewed
Jan 27, 2024
pjfanning
reviewed
Jan 27, 2024
Roiocam
reviewed
Jan 27, 2024
|
@pjfanning , @Roiocam ping with additional simplification from @Roiocam :) |
32 tasks
|
@pjfanning ping for another round of review, I think this is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation：
Add support to test JDK 11, JDK 17, and JDK 21 related code and just add the code when the runtime version matches.
This will help us to detect LTS version-related issues at the nightly build.
With JDK 21:
With JDK 11:
@Roiocam ping for a review too