GH-2994: Optimize string to binary conversion in AvroWriteSupport #2995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Binary.fromCharSequence
is an order of magnitud slower thanBinary.fromString
when input is aString
:Here is the code for the benchmarks:
What changes are included in this PR?
Change
AvroWriteSupport.fromAvroString()
to useBinary.fromString
when operating with string inputs.Are these changes tested?
Current tests should cover the change
Are there any user-facing changes?
No
Closes #2994