Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2921: Remove Jackson JDK8 module #1378

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jun 19, 2024

Not needed anymore :)

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Closes #2921

pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the spotless version isn't bumped in the same diff ;)

* contains file level (Codec, Schema, ...) and block level (location, columns, record count, ...) meta data
*/
public class ParquetMetadata {

private static final ObjectMapper objectMapper = new ObjectMapper();

static {
// Enable FAIL_ON_EMPTY_BEANS on objectmapper. Without this feature parquet-casdacing tests fail,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cascading is long gone :)

@Fokko Fokko added this to the 1.15.0 milestone Jul 13, 2024
@Fokko Fokko requested a review from wgtmac July 13, 2024 20:32
@Fokko Fokko changed the title PARQUET-2501: Remove Jackson JDK8 module GH-2921: Remove Jackson JDK8 module Jul 22, 2024
@Fokko Fokko merged commit 1c76796 into apache:master Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Jackson JDK8 module
3 participants