Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-34: Extend Contains support to all ColumnFilterPredicate types #1370

Merged
merged 2 commits into from
Jun 14, 2024
Merged

PARQUET-34: Extend Contains support to all ColumnFilterPredicate types #1370

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1c45d6
PARQUET-34: Extend Contains support to all ColumnFilterPredicate types
clairemcginty Jun 4, 2024
6ffd4f0
PARQUET-34: Wrap Operator null check in parenthesis
clairemcginty Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
PARQUET-34: Wrap Operator null check in parenthesis
  • Loading branch information
@clairemcginty
clairemcginty committed Jun 13, 2024
commit 6ffd4f0cddcc35234a439dff08c17673e9b1efc4
4 changes: 2 additions & 2 deletions parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,10 +427,10 @@ private static class ContainsColumnPredicate<T extends Comparable<T>, U extends
ContainsColumnPredicate(U underlying) {
super(underlying.getColumn());
if ((underlying instanceof ColumnFilterPredicate && ((ColumnFilterPredicate) underlying).getValue() == null)
|| underlying instanceof SetColumnFilterPredicate
|| (underlying instanceof SetColumnFilterPredicate
&& ((SetColumnFilterPredicate) underlying)
.getValues()
.contains(null)) {
.contains(null))) {
throw new IllegalArgumentException("Contains predicate does not support null element value(s)");
}
this.underlying = underlying;
Expand Down