Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2462: Bump to Thrift 0.20.0 #1327

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 23, 2024

Make sure you have checked all steps below.

0.20.0 comes with Homebrew.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@wgtmac
Copy link
Member

wgtmac commented Apr 23, 2024

Do we need to make sure parquet-mr and parquet-format has same version of thrift? parquet-mr 1.14.0 release will go with parquet-format 2.10.0 which is still on an older version.

@Fokko
Copy link
Contributor Author

Fokko commented Apr 23, 2024

@wgtmac Great question, I think the versions can be different, but I'm happy to defer this PR until 1.14.0 has been released.

@wgtmac
Copy link
Member

wgtmac commented Apr 24, 2024

Both ways are fine to me. Feel free to merge it at any time.

@Fokko Fokko merged commit 5cb50fb into apache:master May 1, 2024
9 checks passed
clairemcginty pushed a commit to clairemcginty/parquet-mr that referenced this pull request May 17, 2024
@asfimport asfimport mentioned this pull request May 1, 2024
@wgtmac wgtmac added this to the 1.15.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants