ORC-151. Minimize the size of the tools uber jar. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 1, 2023
### What changes were proposed in this pull request? This PR aims to remove Apache Zookeeper Runtime dependency for Apache ORC 2.0.0. ### Why are the changes needed? Apache ORC 1.4.0 added Zookeeper depdency to the pom file to reduce the uber file size because Zookeeper is used by Hadoop Common module at that time. - #96 After ORC-1430, Apache ORC 2.0.0 uses Hadoop shaded clients which shaded Zookeeper runtime dependency. We can remove Zookeeper dependency. - #1509 - #1554 ### How was this patch tested? Pass the CIs. This closes #1572 . Closes #1630 from dongjoon-hyun/ORC-1514. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to remove Apache Zookeeper Runtime dependency for Apache ORC 2.0.0. ### Why are the changes needed? Apache ORC 1.4.0 added Zookeeper depdency to the pom file to reduce the uber file size because Zookeeper is used by Hadoop Common module at that time. - apache#96 After ORC-1430, Apache ORC 2.0.0 uses Hadoop shaded clients which shaded Zookeeper runtime dependency. We can remove Zookeeper dependency. - apache#1509 - apache#1554 ### How was this patch tested? Pass the CIs. This closes apache#1572 . Closes apache#1630 from dongjoon-hyun/ORC-1514. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch takes the tools uber jar from 29mb to 23mb.