ORC-1752: Fix NumberFormatException when reading json timestamp type in benchmark #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 5, 2024
…in benchmark ### What changes were proposed in this pull request? This PR aims to fix NumberFormatException when reading json timestamp type in benchmark. ### Why are the changes needed? Because the source data of the benchmark has two timestamp formats, we need to be compatible with both Long and String timestamp formats. ```java Exception in thread "main" java.lang.NumberFormatException: For input string: "2015-11-04T12:00:00Z" at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67) at java.base/java.lang.Long.parseLong(Long.java:711) at java.base/java.lang.Long.parseLong(Long.java:836) at com.google.gson.JsonPrimitive.getAsLong(JsonPrimitive.java:206) at org.apache.orc.bench.core.convert.json.JsonReader$TimestampColumnConverter.convert(JsonReader.java:175) at org.apache.orc.bench.core.convert.json.JsonReader.nextBatch(JsonReader.java:86) at org.apache.orc.bench.core.convert.GenerateVariants$RecursiveReader.nextBatch(GenerateVariants.java:195) at org.apache.orc.bench.core.convert.GenerateVariants.run(GenerateVariants.java:154) at org.apache.orc.bench.core.Driver.main(Driver.java:64) ``` ### How was this patch tested? ```bash java -jar core/target/orc-benchmarks-core-*-uber.jar generate data java -jar core/target/orc-benchmarks-core-*-uber.jar scan data ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes #1995 from cxzl25/ORC-1752. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 954ba0c) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Merged to main/2.0. |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 5, 2024
### What changes were proposed in this pull request? This PR aims to use Apache Avro 1.12.0 in `bench` module. ### Why are the changes needed? Apache Avro 1.12.0 is the latest feature release. Since we are fixing this area recently, we had better keep it up-to-date in order to avoid re-validation in the future. - #1930 - #1995 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1996 from dongjoon-hyun/ORC-1753. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 5, 2024
### What changes were proposed in this pull request? This PR aims to use Apache Avro 1.12.0 in `bench` module. ### Why are the changes needed? Apache Avro 1.12.0 is the latest feature release. Since we are fixing this area recently, we had better keep it up-to-date in order to avoid re-validation in the future. - #1930 - #1995 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1996 from dongjoon-hyun/ORC-1753. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit e43ce79) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix NumberFormatException when reading json timestamp type in benchmark.
Why are the changes needed?
Because the source data of the benchmark has two timestamp formats, we need to be compatible with both Long and String timestamp formats.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No