Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS #1963

Closed
wants to merge 10 commits into from
Closed

ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS #1963

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
032d9a6
ORC-1732:[C++] fix failure to detect Protobuf installed by Homebrew o…
luffy-zh Jun 27, 2024
18dac8c
format code
luffy-zh Jun 27, 2024
6f29a36
add macos ci job test
luffy-zh Jul 1, 2024
4abc8d1
fix build_and_test run failure
luffy-zh Jul 3, 2024
e6ad656
Update .github/workflows/build_and_test.yml
luffy-zh Jul 8, 2024
30108ae
Update .github/workflows/build_and_test.yml
luffy-zh Jul 8, 2024
8958559
Update cmake_modules/FindProtobuf.cmake
luffy-zh Jul 9, 2024
a9326e8
Update cmake_modules/FindProtobuf.cmake
luffy-zh Jul 9, 2024
7ddf8ce
Update cmake_modules/FindProtobuf.cmake
luffy-zh Jul 9, 2024
d479f05
add 12 to macOS version list
luffy-zh Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update cmake_modules/FindProtobuf.cmake 
Co-authored-by: Sutou Kouhei <[email protected]>
  • Loading branch information
@luffy-zh @kou
luffy-zh and kou authored Jul 9, 2024
commit 7ddf8ced61c8223f85313d133323d4b0834a47e2
2 changes: 1 addition & 1 deletion cmake_modules/FindProtobuf.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ if (Protobuf_FOUND)
if (NOT PROTOBUF_INCLUDE_DIR)
set (PROTOBUF_INCLUDE_DIR ${Protobuf_INCLUDE_DIRS})
if (NOT PROTOBUF_INCLUDE_DIR)
message(FATAL_ERROR "Cannot determine Protobuf include directory from protobuf::libprotobuf and Protobuf_INCLUDE_DIRS.")
message (FATAL_ERROR "Cannot determine Protobuf include directory from protobuf::libprotobuf and Protobuf_INCLUDE_DIRS.")
endif ()
endif ()
else ()
Expand Down
Loading