-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp #1949
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Please see my inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM for 2.1.0.
Thanks @ffacs and @dongjoon-hyun! I just merged it |
What changes were proposed in this pull request?
{stirng, char, varchar}
to{decimal,timestamp,timestamp_instant}
varchar
tovarchar
andchar
tochar
Why are the changes needed?
To support Schema evolution at c++ side.
How was this patch tested?
UT passed
Was this patch authored or co-authored using generative AI tooling?
NO