Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp #1949

Closed
wants to merge 7 commits into from

Conversation

ffacs
Copy link
Contributor

@ffacs ffacs commented Jun 3, 2024

What changes were proposed in this pull request?

  1. Support schema evolution from {stirng, char, varchar} to {decimal,timestamp,timestamp_instant}
  2. Fix a bug that cannot convert from varchar to varchar and char to char

Why are the changes needed?

To support Schema evolution at c++ side.

How was this patch tested?

UT passed

Was this patch authored or co-authored using generative AI tooling?

NO

@github-actions github-actions bot added the CPP label Jun 3, 2024
@cxzl25 cxzl25 changed the title ORC-1390 [C++] Support schema evolution from string group to decimal/… ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp Jun 3, 2024
@ffacs
Copy link
Contributor Author

ffacs commented Jun 4, 2024

strptime and timegm are not c/c++ standard function, maybe I should implement them by myself.

@ffacs ffacs marked this pull request as draft June 7, 2024 15:15
@ffacs ffacs marked this pull request as ready for review June 7, 2024 17:27
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Please see my inline comments.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM for 2.1.0.

@dongjoon-hyun dongjoon-hyun added this to the 2.1.0 milestone Jul 9, 2024
@wgtmac wgtmac closed this in dc7afc6 Jul 12, 2024
@wgtmac
Copy link
Member

wgtmac commented Jul 12, 2024

Thanks @ffacs and @dongjoon-hyun! I just merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants