add NO_SANITIZE_ATTR to Adaptor.hh.in

apache · Feb 6, 2025 · 07bd591 · 07bd591
1 parent 003f4f2
commit 07bd591
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/c++/src/Adaptor.hh.in b/c++/src/Adaptor.hh.in
@@ -49,6 +49,12 @@ typedef SSIZE_T ssize_t;
   ssize_t pread(int fd, void* buf, size_t count, off_t offset);
 #endif
 
+#if defined(__GNUC__) || defined(__clang__)
+  #define NO_SANITIZE_ATTR __attribute__((no_sanitize("signed-integer-overflow", "shift")))
+#else
+  #define NO_SANITIZE_ATTR
+#endif
+
 #ifdef HAS_DIAGNOSTIC_PUSH
   #ifdef __clang__
     #define DIAGNOSTIC_PUSH _Pragma("clang diagnostic push")

diff --git a/c++/src/BloomFilter.cc b/c++/src/BloomFilter.cc
@@ -226,7 +226,7 @@ namespace orc {
     }
   }
 
-  __attribute__((no_sanitize("signed-integer-overflow","shift")))
+  NO_SANITIZE_ATTR
   bool BloomFilterImpl::testHash(int64_t hash64) const {
     int32_t hash1 = static_cast<int32_t>(hash64 & 0xffffffff);
     // In Java codes, we use "hash64 >>> 32" which is an unsigned shift op.

diff --git a/c++/src/BloomFilter.hh b/c++/src/BloomFilter.hh
@@ -19,6 +19,7 @@
 #ifndef ORC_BLOOMFILTER_IMPL_HH
 #define ORC_BLOOMFILTER_IMPL_HH
 
+#include "Adaptor.hh"
 #include "orc/BloomFilter.hh"
 #include "wrap/orc-proto-wrapper.hh"
 

diff --git a/c++/src/RLE.hh b/c++/src/RLE.hh
@@ -19,6 +19,7 @@
 #ifndef ORC_RLE_HH
 #define ORC_RLE_HH
 
+#include "Adaptor.hh"
 #include "io/InputStream.hh"
 #include "io/OutputStream.hh"