Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max body size limit #365

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Fix max body size limit #365

merged 2 commits into from
Dec 4, 2019

Conversation

mhamann
Copy link
Member

@mhamann mhamann commented Nov 5, 2019

Fixes #364

@rabbah
Copy link
Member

rabbah commented Nov 5, 2019

given this is a fix for a previous fix is there a way to test this change as part of our ci?

@mhamann
Copy link
Member Author

mhamann commented Nov 5, 2019

@rabbah there's an issue open to create a set of "integration-like" tests for the gateway, which I think is critical to the health of the codebase as things continue to evolve. I'm hoping to put a framework for that in place before the end of the year, and then build out missing test coverage over time. This test would definitely fall into that bucket.

I know there are some gateway tests in the main openwhisk repo, but I believe those should be geared more toward end-to-end scenarios.

Let me know if you have a different perspective on the problem.

@mhamann mhamann merged commit 4d1fbf5 into master Dec 4, 2019
@mhamann mhamann deleted the file-upload-size branch December 4, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client_max_body_size limit not taking effect
2 participants