Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array handling during mapping operations #359

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Fix array handling during mapping operations #359

merged 1 commit into from
Apr 1, 2020

Conversation

mhamann
Copy link
Member

@mhamann mhamann commented Sep 25, 2019

Related to #324

rabbah
rabbah approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this does. I trust you do. If this is related to #324 should there be a test? I’ll approve and defer to you but a test would help clarify this change or 324’s.

@mhamann mhamann merged commit 519f1e9 into master Apr 1, 2020
@mhamann mhamann deleted the json-handling branch April 1, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabbah rabbah rabbah approved these changes

@dgrove-oss dgrove-oss Awaiting requested review from dgrove-oss

@ddragosd ddragosd Awaiting requested review from ddragosd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhamann @rabbah