-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENNLP-1567 - OpenNLP Models: Provide a Finder / Loader Implementation #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @rzo1. I left some review comments and feedback with one major topic open for discussion (introducing classgraph as a dependency).
opennlp-tools-models/src/main/java/opennlp/tools/models/ClasspathModelFinder.java
Outdated
Show resolved
Hide resolved
opennlp-tools-models/src/main/java/opennlp/tools/models/ClasspathModelFinder.java
Outdated
Show resolved
Hide resolved
opennlp-tools-models/src/main/java/opennlp/tools/models/ClasspathModelFinder.java
Outdated
Show resolved
Hide resolved
opennlp-tools-models/src/main/java/opennlp/tools/models/ClasspathModelFinder.java
Outdated
Show resolved
Hide resolved
opennlp-tools-models/src/main/java/opennlp/tools/models/ClasspathModelFinder.java
Outdated
Show resolved
Hide resolved
opennlp-tools-models/src/test/java/opennlp/tools/models/ClassPathModelFinderTest.java
Outdated
Show resolved
Hide resolved
opennlp-tools-models/src/test/java/opennlp/tools/models/ClassPathModelLoaderTest.java
Outdated
Show resolved
Hide resolved
opennlp-tools-models/src/test/java/opennlp/tools/models/ClassPathModelUsageTest.java
Outdated
Show resolved
Hide resolved
Since I don't have a Windows system anymore, this PR needs someone with a Windows machine to check the implementation of Windows and Linux/OSX have a difference in the classpath separator |
201611c
to
98e2970
Compare
Tests on a local Windows 10 are ok now (via IDE + Maven). CI is still complaining, so requires some more digging in that area ;-) |
This is fixed now. Removing DRAFT state. |
Built and tested fine on Windows 11.
|
# Conflicts: # opennlp-tools-models/pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @rzo1
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
This adds a proof-of-conept implementation as a separate module (due to the addtional dependendy for classpath scanning) to load models from JAR files.
If we are fine with the design, we can do a first model release afterwards ;-)