Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1567 - OpenNLP Models: Provide a Finder / Loader Implementation #606

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jun 11, 2024

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

This adds a proof-of-conept implementation as a separate module (due to the addtional dependendy for classpath scanning) to load models from JAR files.

If we are fine with the design, we can do a first model release afterwards ;-)

@rzo1 rzo1 requested review from kinow, jzonthemtn and mawiesne June 11, 2024 09:35
@rzo1 rzo1 self-assigned this Jun 11, 2024
@rzo1 rzo1 force-pushed the opennlp-models branch from dcbdc17 to fd9cd00 Compare June 12, 2024 19:26
@rzo1 rzo1 requested a review from kinow June 12, 2024 19:27
Copy link
Contributor

@mawiesne mawiesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @rzo1. I left some review comments and feedback with one major topic open for discussion (introducing classgraph as a dependency).

@rzo1 rzo1 requested a review from mawiesne June 14, 2024 08:44
@rzo1 rzo1 marked this pull request as draft June 14, 2024 10:14
@rzo1 rzo1 force-pushed the opennlp-models branch from c7dce30 to dce8828 Compare June 14, 2024 19:38
@rzo1 rzo1 marked this pull request as ready for review June 14, 2024 19:39
@rzo1
Copy link
Contributor Author

rzo1 commented Jun 14, 2024

Since I don't have a Windows system anymore, this PR needs someone with a Windows machine to check the implementation of SimpleClassPathModelFinder and the related tests (which are fine for OSX / Linux) ... ;-)

Windows and Linux/OSX have a difference in the classpath separator ; vs :. I think, that the parsing and matching of URI (fragments) doesn't account for the Windows-specifics yet. I might have access to a Windows with IDE next week, so marking this PR as draft again (for now).

@rzo1 rzo1 marked this pull request as draft June 14, 2024 19:55
@rzo1 rzo1 force-pushed the opennlp-models branch 5 times, most recently from 201611c to 98e2970 Compare June 17, 2024 06:58
@rzo1
Copy link
Contributor Author

rzo1 commented Jun 17, 2024

Tests on a local Windows 10 are ok now (via IDE + Maven). CI is still complaining, so requires some more digging in that area ;-)

@rzo1 rzo1 force-pushed the opennlp-models branch from 98e2970 to 9652d4e Compare June 17, 2024 07:00
@rzo1 rzo1 force-pushed the opennlp-models branch from 9652d4e to a139637 Compare June 17, 2024 07:22
@rzo1
Copy link
Contributor Author

rzo1 commented Jun 17, 2024

Tests on a local Windows 10 are ok now (via IDE + Maven). CI is still complaining, so requires some more digging in that area ;-)

This is fixed now. Removing DRAFT state.

@rzo1 rzo1 marked this pull request as ready for review June 17, 2024 07:27
@jzonthemtn
Copy link
Contributor

Built and tested fine on Windows 11.

Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: C:\Program Files\apache-maven-3.9.8
Java version: 21.0.1, vendor: Amazon.com Inc., runtime: C:\Program Files\Amazon Corretto\jdk21.0.1_12
Default locale: en_US, platform encoding: UTF-8
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

Copy link
Contributor

@mawiesne mawiesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @rzo1

@rzo1 rzo1 merged commit 1b6ef86 into main Jun 18, 2024
10 checks passed
@rzo1 rzo1 deleted the opennlp-models branch June 18, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants