Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1564 - Fix Evaluation Tests after POSFormat Change #603

Merged
merged 2 commits into from
May 30, 2024

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented May 29, 2024

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Updates some missed PENN format cases in the evaluation test data. In addition, if POSTaggerNameFeatureGenerator is used for NameFinder (i.e. defined via XML), we only get a POSModel and need to guess the format of it before creating the POSTagger. Therefore, I updated the mapper with a static method for guessing this type based on a given POSModel. This might be useful for other cases as well.

Sadly, ASF Jenkins is currently broken, so we cannot trigger a manual run, see https://issues.apache.org/jira/browse/INFRA-25828

rzo1 added 2 commits May 29, 2024 20:43
…al tests. Allow specification of POSTagFormat for POSTaggerCrossValidator.
…FeatureGenerator (e.g. defined in XML), we need to actually guess the format out of a given POSModel to initalize the POSTagger correctly.
@rzo1 rzo1 requested review from kinow, jzonthemtn and mawiesne May 29, 2024 19:05
@rzo1
Copy link
Contributor Author

rzo1 commented May 30, 2024

Thanks for review. I will merge, so it gets picked up in today's scheduled eval run. Will close Jira, If the run is green (otherwise, debug session 😁)

@rzo1 rzo1 merged commit 7a7e013 into main May 30, 2024
10 checks passed
@rzo1 rzo1 deleted the fix-eval-tests-after-pos-tagging-conversion branch July 2, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants