Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try use logforth #5573

Merged
merged 2 commits into from
Jan 27, 2025
Merged

chore: try use logforth #5573

merged 2 commits into from
Jan 27, 2025

Conversation

tisonkun
Copy link
Member

Somehow self-promoted. More affinity to the log crate.

Copy link

codspeed-hq bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #5573 will not alter performance

Comparing use-logforth (2c13830) with main (cdbcc0f)

Summary

✅ 73 untouched benchmarks

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tisonkun for this. I'm open to this change as long as it not touching core/src.

@tisonkun
Copy link
Member Author

it not touching core/src

Yeah. I reviewed that and notice there is already a tracing dependencies for the layer and I think no need so far to make changes there.

@tisonkun tisonkun merged commit c6fe050 into main Jan 27, 2025
278 checks passed
@tisonkun tisonkun deleted the use-logforth branch January 27, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants