Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): Try just instead of xtasks methods #5461

Merged
merged 3 commits into from
Dec 26, 2024
Merged

chore(dev): Try just instead of xtasks methods #5461

merged 3 commits into from
Dec 26, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 26, 2024

Which issue does this PR close?

Part of #5460

Rationale for this change

See #5460

What changes are included in this PR?

Add justfile as a start.

Are there any user-facing changes?

Dev Only.

Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to use this file?

I don't remember we have a requirement to "generate language".

That is, I'd like to know how this command helps and how should I use it to resolve a real problem.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 26, 2024

How to use this file?

Updated the dev/README.md files.

```bash
cargo o help
just --list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should include a section about how to install just or at least a link to the just project.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experience looks good. Better than make that we can list and run in any subdir.

Let's give it a try and even further.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 26, 2024

Thank you @tisonkun for the review, let's move on!

@Xuanwo Xuanwo merged commit 26a2bfe into main Dec 26, 2024
12 checks passed
@Xuanwo Xuanwo deleted the try-just branch December 26, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants