Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(services/memory): MemoryConfig implement Debug #4942

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fix(services/memory): MemoryConfig implement Debug #4942

merged 3 commits into from
Jul 29, 2024

Conversation

0x676e67
Copy link
Contributor

@0x676e67 0x676e67 commented Jul 29, 2024 •
edited by Xuanwo
Loading

Fix: #4941

@0x676e67 0x676e67 requested a review from Xuanwo as a code owner July 29, 2024 13:53
@0x676e67 0x676e67 changed the title fix: MemoryConfig implement Debug fix(services/memory): MemoryConfig implement Debug Jul 29, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Jul 29, 2024

Thanks for this change! Would you like to add Debug for Configurator to avoid this happen of other services?

@0x676e67
Copy link
Contributor Author

sure!

Xuanwo
Xuanwo approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit e05e310 into apache:main Jul 29, 2024
222 checks passed
ho-229 pushed a commit to ho-229/incubator-opendal that referenced this pull request Aug 6, 2024
@0x676e67 @ho-229
fix(services/memory): MemoryConfig implement Debug (apache#4942)
5de060c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: MemoryConfig doesn't implement Debug
2 participants
@0x676e67 @Xuanwo