Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(service/redis): Migrate task to new task planner #3374

Merged
merged 10 commits into from
Nov 17, 2023
Merged

refactor(service/redis): Migrate task to new task planner #3374

merged 10 commits into from
Nov 17, 2023

Conversation

sunheyi6
Copy link
Contributor

No description provided.

Xuanwo
Xuanwo requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redis is intentionally left as it is, because we have some complex features to sort out.

@Xuanwo
Copy link
Member

Xuanwo commented Nov 3, 2023

#3471 has been merged, you can continue your work now!

@sunheyi6
Merge branch 'main' into redis-tls
3272e7e 
# Conflicts:
#	.github/workflows/service_test_redis.yml
@sunheyi6
Copy link
Contributor Author

sunheyi6 commented Nov 6, 2023

@Xuanwo cc

Xuanwo
Xuanwo reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing CI first.

.github/services/redis/redis_with_cluster_tls/action.yml Outdated Show resolved Hide resolved
@sunheyi6
Copy link
Contributor Author

@G-XD Can you help me check why my redis-with-cluster-cls did not pass the CI test? I have tried quite a bit, but it seems that I can't solve this problem.

@sunheyi6
Copy link
Contributor Author

@PsiACE cc

PsiACE
PsiACE approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sunheyi6
Copy link
Contributor Author

@Xuanwo cc

@Xuanwo Xuanwo merged commit ae1a534 into apache:main Nov 17, 2023
@G-XD G-XD mentioned this pull request Nov 17, 2023
Closed
86 tasks
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-XD G-XD G-XD left review comments

@PsiACE PsiACE PsiACE approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunheyi6 @Xuanwo @PsiACE @G-XD