RFC-3197: Config

[Xuanwo]

• Close idea: Move root out of service config to operator level? #3151
• Close idea: Expose services options so that users can working on struct directly? #3152

[xyjixyjixyji]

Just a thought, what about add a interface in trait Builder

fn config(&self) -> Box<dyn Config>

And let Config itself be

trait Config: Serialize + Deserialize + ....

This makes it more maintainable and less error prone

For example S3

impl Config for S3Config {
...
}

and

impl Builder for S3Builder {
    fn config(&self) -> Box<dyn Config> {
        self.config.boxed()
   }
}

[Xuanwo]

trait Config: Serialize + Deserialize + ....

Providing a trait that allows Serialize + Deserialize is different from providing structs/enums that supports Serialize + Deserialize. The structs/enums allows users to work directly with detailed configuration.

Users can implement TryFrom/TryInto according to their own needs.

This is crucial for production applications as they do not want to be impacted by OpenDAL's breaking changes. And they should not.

[Xuanwo]

Hi, @oowl, please don't force push my branches. Thanks.

[damooo]

For dealing with secrets, there is secrecy

[Xuanwo]

For dealing with secrets, there is secrecy

Thank you for the advice. However, as stated in the proposal, this does not include anything related to secrets.

[Xuanwo]

cc @suyanhanx @Ji-Xinyou @ClSlaid would you like to review again?

[xyjixyjixyji]

LGTM now

[Xuanwo]

Hi, @suyanhanx, do you have any review comments to address?

[suyanhanx]

LGTM. Thanks.