feat(services/redis): enable TLS #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stormshield-robinc
requested review from
Xuanwo,
PsiACE,
ClSlaid and
sundy-li
as code owners
Stormshield-robinc
force-pushed
the
redis_tls
branch
from
b719be5 to
e3f5fa9
Compare
oowl
reviewed
Jul 19, 2023
Xuanwo
reviewed
Jul 19, 2023
Stormshield-robinc
force-pushed
the
redis_tls
branch
from
1cb2f61 to
ecf0626
Compare
Xuanwo
approved these changes
Jul 20, 2023
Stormshield-robinc
force-pushed
the
redis_tls
branch
from
5a4db6e to
9f30707
Compare
Stormshield-robinc
force-pushed
the
redis_tls
branch
from
9f30707 to
e377027
Compare
|
Thanks! |
|
Thanks for your reviews. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable TLS support for redis since redis-rs now support rustls
#2669
Note : in the sccache documentation for redis (https://github.com/mozilla/sccache/blob/main/docs/Redis.md) it seem that it was possible to add a
#insecureto url. Is this something you would be interested in ?