Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/persy): add a basic persy service impl #2648

Merged
merged 9 commits into from
Jul 16, 2023
Merged

feat(services/persy): add a basic persy service impl #2648

merged 9 commits into from
Jul 16, 2023

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jul 16, 2023

This PR has initially implemented support for the persy backend, and added corresponding CI and documentation.

# persy
OPENDAL_PERSY_TEST=false
## That path to the persy data file. The directory in the path must already exist.
OPENDAL_PERSY_DATAFILE=/tmp/opendal/test.persy
OPENDAL_PERSY_SEGMENT=data
OPENDAL_PERSY_INDEX=index

Fixes: #2522

@PsiACE
chore: cargo fmt
0c01416 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE PsiACE requested a review from suyanhanx July 16, 2023 05:53
@PsiACE
Copy link
Member Author

PsiACE commented Jul 16, 2023

also cc @Anakin100100 , sorry for the delay, but perhaps you would be willing to help review.

@PsiACE
chore(ci): remove j=1
c4dfb4b 
Signed-off-by: Chojan Shang <[email protected]>
Xuanwo
Xuanwo reviewed Jul 16, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM

core/src/services/persy/backend.rs Outdated Show resolved Hide resolved
core/src/services/persy/backend.rs Show resolved Hide resolved
core/src/services/persy/backend.rs Outdated Show resolved Hide resolved
@PsiACE
chore: fix comments style
9246e8f 
Signed-off-by: Chojan Shang <[email protected]>
Xuanwo
Xuanwo approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 7803c41 into apache:main Jul 16, 2023
@PsiACE PsiACE deleted the service-persy branch July 16, 2023 18:17
@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new service support: persy
3 participants
@PsiACE @Xuanwo @suyanhanx