Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/dotnet): basic structure #2485

Merged
merged 19 commits into from
Jun 18, 2023
Merged

Conversation

tisonkun
Copy link
Member

This refers to #2428.

You can run with -

./build.py --classifier osx-aarch_64
dotnet test 

tisonkun added 14 commits June 18, 2023 12:03
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
bindings/dotnet/src/lib.rs Outdated Show resolved Hide resolved
tisonkun added 2 commits June 18, 2023 17:16
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
@tisonkun tisonkun mentioned this pull request Jun 18, 2023
Signed-off-by: tison <[email protected]>
Cargo.toml Show resolved Hide resolved
bindings/dotnet/Cargo.toml Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Jun 18, 2023

Mostly LGTM. Perhaps we can merge this pull request first and then polish it?

@tisonkun
Copy link
Member Author

Mostly LGTM. Perhaps we can merge this pull request first and then polish it?

Yes. Two major improvement should be done are -

  1. Marshalling and Unmarshalling struct (maybe including strings);
  2. Building and distributing (via NuGet).

References are provided in the tracking issue, while I may not be able to find some time dig into it until the next month.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit eead5d2 into apache:main Jun 18, 2023
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
@tisonkun tisonkun deleted the csharp-bindings branch September 27, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants