Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings/haskell): add Monad wrapper #2482

Merged
merged 3 commits into from
Jun 18, 2023
Merged

feat(bindings/haskell): add Monad wrapper #2482

merged 3 commits into from
Jun 18, 2023

Conversation

silver-ymz
Copy link
Member

Update:

  • add MonadOperation typeclass to provide flexible API
  • add OpMonad to provide basic Monad for user
  • add tests testMonad and testError

@silver-ymz
add tests for memory
0d86ad6 
Signed-off-by: silver-ymz <[email protected]>
Xuanwo
Xuanwo reviewed Jun 18, 2023
View reviewed changes
bindings/haskell/test/BasicTest.hs Outdated Show resolved Hide resolved
bindings/haskell/test/BasicTest.hs Outdated Show resolved Hide resolved
@silver-ymz
only test for memory
954395e 
Signed-off-by: silver-ymz <[email protected]>
Xuanwo
Xuanwo approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit fcda0be into apache:main Jun 18, 2023
@silver-ymz silver-ymz mentioned this pull request Jun 25, 2023
Closed
6 tasks
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silver-ymz @Xuanwo