Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/azblob): Fix azblob batch max operations #2434

Merged

Conversation

A-Stupid-Sun
Copy link
Contributor

Fix azblob service config of batch max operations
close issue #2228

Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other part LGTM, thanks!

core/src/services/azblob/backend.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work @A-Stupid-Sun! Let's wait for the CI to pass.

@xyjixyjixyji xyjixyjixyji merged commit 974ceb0 into apache:main Jun 8, 2023
@A-Stupid-Sun A-Stupid-Sun deleted the fix-azblob_batch_max_operations branch June 8, 2023 06:54
@Xuanwo
Copy link
Member

Xuanwo commented Jun 8, 2023

cc @A-Stupid-Sun, We should also load batch max operations from_map.

@A-Stupid-Sun A-Stupid-Sun restored the fix-azblob_batch_max_operations branch June 8, 2023 07:18
@A-Stupid-Sun
Copy link
Contributor Author

cc @A-Stupid-Sun, We should also load batch max operations from_map.

https://github.com/apache/incubator-opendal/blob/f9e954d78b247695e93b3fd60ee6544e6e5884b1/core/src/services/azblob/backend.rs#L370-L371

cc @Xuanwo

@A-Stupid-Sun A-Stupid-Sun deleted the fix-azblob_batch_max_operations branch June 8, 2023 08:04
@Xuanwo
Copy link
Member

Xuanwo commented Jun 8, 2023

I missed this. Thanks for pointing out!

@PsiACE PsiACE mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants