Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings/c): add opendal_operator_blocking_delete method #2416

Merged
merged 1 commit into from
Jun 5, 2023
Merged

feat(bindings/c): add opendal_operator_blocking_delete method #2416

merged 1 commit into from
Jun 5, 2023

Conversation

jiaoew1991
Copy link
Contributor

No description provided.

@Xuanwo Xuanwo requested a review from xyjixyjixyji June 5, 2023 08:39
@jiaoew1991 jiaoew1991 force-pushed the c-blocking-delete branch from c240128 to 99389fe Compare June 5, 2023 08:48
xyjixyjixyji
xyjixyjixyji reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, the function implementation is basically correct. But there exists a few points that need some polishments 😃

bindings/c/src/lib.rs Outdated Show resolved Hide resolved
bindings/c/src/lib.rs Show resolved Hide resolved
bindings/c/tests/bdd.cpp Show resolved Hide resolved
bindings/c/src/lib.rs Show resolved Hide resolved
@jiaoew1991 jiaoew1991 force-pushed the c-blocking-delete branch 2 times, most recently from c4cdefa to 03e018d Compare June 5, 2023 09:47
xyjixyjixyji
xyjixyjixyji approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! Lets wait the CI to pass.

@xyjixyjixyji xyjixyjixyji merged commit c3868eb into apache:main Jun 5, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyjixyjixyji xyjixyjixyji xyjixyjixyji approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiaoew1991 @Xuanwo @xyjixyjixyji