-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): server side encryption support for azblob #2347
feat(core): server side encryption support for azblob #2347
Conversation
I prefer to have separately options which is easier to be fetched from env or hashmap. And we can provide a |
fe6241f
to
2e4b8ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM, thanks a lot!
d8719dc
to
8d4e4dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks a lot!
Description
Changes Made
Add SSE headers into these requests
Additional Notes
Helper Function Design
Hi @Xuanwo, what do you think about these two functions? Should we provide them separately or together? (Also, since azblob only support for AES256 as encryption algorithm, do we still need to provide setting options for user?)
Test Case Design
I haven't implemented testing for this change, any suggestion? (I assume it can leverage Azurite in GitHub Actions)