refactor: Minimize futures dependencies #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
requested review from
messense,
suyanhanx,
Xuanwo,
PsiACE,
ClSlaid and
sundy-li
as code owners
tottoto
force-pushed
the
replace-futures-with-futures-util
branch
from
dbd653e to
b30c2f9
Compare
Xuanwo
reviewed
May 10, 2023
This reverts commit eb3664f.
tottoto
changed the title
|
I changed this pull request title to describe the current purposes. |
|
Thanks for your review! I fixed it and the ci is green. |
Xuanwo
reviewed
May 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
futureswithfutures-utilto reduce unused trailing dependencies. Currently we still depend onfuturesviabackonbut it was fixed at Xuanwo/backon#47 and when it releases we can removefuturesfrom our dependency tree.