feat(services/memory): migrate service memory #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
|
Show some benchmarks 🚀, the benchmark itself seems unstable. service_memory_read_full/4.00 KiB
time: [952.53 ns 952.77 ns 953.02 ns]
thrpt: [4.0028 GiB/s 4.0038 GiB/s 4.0048 GiB/s]
change:
time: [-7.6826% -7.4576% -7.2313%] (p = 0.00 < 0.05)
thrpt: [+7.7950% +8.0585% +8.3219%]
Performance has improved.
service_memory_read_full/256 KiB
time: [65.307 µs 65.558 µs 65.765 µs]
thrpt: [3.7123 GiB/s 3.7241 GiB/s 3.7383 GiB/s]
change:
time: [+573.28% +579.84% +586.81%] (p = 0.00 < 0.05)
thrpt: [-85.440% -85.291% -85.147%]
Performance has regressed.
service_memory_read_full/4.00 MiB
time: [1.0436 ms 1.0446 ms 1.0457 ms]
thrpt: [3.7357 GiB/s 3.7396 GiB/s 3.7432 GiB/s]
change:
time: [+717.03% +722.26% +727.62%] (p = 0.00 < 0.05)
thrpt: [-87.917% -87.838% -87.761%]
Performance has regressed.
service_memory_read_full/16.0 MiB
time: [214.32 µs 215.09 µs 215.77 µs]
thrpt: [72.415 GiB/s 72.645 GiB/s 72.905 GiB/s]
change:
time: [-71.389% -71.098% -70.840%] (p = 0.00 < 0.05)
thrpt: [+242.93% +245.99% +249.52%]
Performance has improved.
service_memory_read_part/4.00 KiB
time: [993.14 ns 995.71 ns 998.68 ns]
thrpt: [3.8197 GiB/s 3.8311 GiB/s 3.8411 GiB/s]
change:
time: [-9.5393% -9.2148% -8.9114%] (p = 0.00 < 0.05)
thrpt: [+9.7832% +10.150% +10.545%]
Performance has improved.
service_memory_read_part/256 KiB
time: [95.243 µs 95.276 µs 95.317 µs]
thrpt: [2.5614 GiB/s 2.5625 GiB/s 2.5633 GiB/s]
change:
time: [+277.54% +277.78% +278.01%] (p = 0.00 < 0.05)
thrpt: [-73.546% -73.529% -73.513%]
Performance has regressed.
service_memory_read_part/4.00 MiB
time: [95.918 µs 95.975 µs 96.044 µs]
thrpt: [40.672 GiB/s 40.701 GiB/s 40.725 GiB/s]
change:
time: [-73.025% -72.757% -72.505%] (p = 0.00 < 0.05)
thrpt: [+263.70% +267.07% +270.72%]
Performance has improved.
service_memory_read_part/16.0 MiB
time: [6.0835 ms 6.0844 ms 6.0854 ms]
thrpt: [2.5676 GiB/s 2.5680 GiB/s 2.5684 GiB/s]
change:
time: [-4.5343% -3.4569% -2.5650%] (p = 0.00 < 0.05)
thrpt: [+2.6325% +3.5807% +4.7497%]
Performance has improved. |
Xuanwo
approved these changes
May 8, 2023
|
suyanhanx
pushed a commit
to suyanhanx/opendal
that referenced
this pull request
May 8, 2023
* feat(services/memory): migrate service memory Signed-off-by: Chojan Shang <[email protected]> * docs(typed_kv): update capabilities Signed-off-by: Chojan Shang <[email protected]> --------- Signed-off-by: Chojan Shang <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also docs(typed_kv): update capabilities
fixes: #2223